ghsa-9p8x-f768-wp2g
Vulnerability from github
Impact
An attacker may be able to exploit this vulnerability to bypass authentication or authorization mechanisms in systems that rely on xml-crypto for verifying signed XML documents. The vulnerability allows an attacker to modify a valid signed XML message in a way that still passes signature verification checks. For example, it could be used to alter critical identity or access control attributes, enabling an attacker with a valid account to escalate privileges or impersonate another user.
Patches
All versions <= 6.0.0 are affected. Please upgrade to version 6.0.1.
If you are still using v2.x or v3.x please upgrade to the associated patch version.
Indicators of Compromise
When logging XML payloads, check for the following indicators. If the payload includes encrypted elements, ensure you analyze the decrypted version for a complete assessment. (If encryption is not used, analyze the original XML document directly). This applies to various XML-based authentication and authorization flows, such as SAML Response payloads.
Multiple SignedInfo Nodes
There should not be more than one SignedInfo node inside a Signature. If you find multiple SignedInfo nodes, it could indicate an attack.
xml
<Signature>
<SomeNode>
<SignedInfo>
<Reference URI="somefakereference">
<DigestValue>forgeddigestvalue</DigestValue>
</Reference>
</SignedInfo>
</SomeNode>
<SignedInfo>
<Reference URI="realsignedreference">
<DigestValue>realdigestvalue</DigestValue>
</Reference>
</SignedInfo>
</SignedInfo>
</Signature>
Code to test
Pass in the decrypted version of the document ```js decryptedDocument = ... // yours to implement
// This check is per-Signature node, not per-document const signedInfoNodes = xpath.select(".//*[local-name(.)='SignedInfo']", signatureNode);
if (signedInfoNodes.length === 0) { // Not necessarily a compromise, but invalid. Should contain exactly one SignedInfo node // Yours to implement }
if (signedInfoNodes.length > 1) { // Compromise detected, yours to implement } ```
{ "affected": [ { "package": { "ecosystem": "npm", "name": "xml-crypto" }, "ranges": [ { "events": [ { "introduced": "4.0.0" }, { "fixed": "6.0.1" } ], "type": "ECOSYSTEM" } ] }, { "package": { "ecosystem": "npm", "name": "xml-crypto" }, "ranges": [ { "events": [ { "introduced": "3.0.0" }, { "fixed": "3.2.1" } ], "type": "ECOSYSTEM" } ] }, { "package": { "ecosystem": "npm", "name": "xml-crypto" }, "ranges": [ { "events": [ { "introduced": "0" }, { "fixed": "2.1.6" } ], "type": "ECOSYSTEM" } ] } ], "aliases": [ "CVE-2025-29774" ], "database_specific": { "cwe_ids": [ "CWE-347" ], "github_reviewed": true, "github_reviewed_at": "2025-03-14T17:14:23Z", "nvd_published_at": "2025-03-14T17:15:52Z", "severity": "CRITICAL" }, "details": "# Impact\nAn attacker may be able to exploit this vulnerability to bypass authentication or authorization mechanisms in systems that rely on xml-crypto for verifying signed XML documents. The vulnerability allows an attacker to modify a valid signed XML message in a way that still passes signature verification checks. For example, it could be used to alter critical identity or access control attributes, enabling an attacker with a valid account to escalate privileges or impersonate another user.\n\n# Patches\nAll versions \u003c= 6.0.0 are affected. Please upgrade to version 6.0.1.\n\nIf you are still using v2.x or v3.x please upgrade to the associated patch version.\n\n# Indicators of Compromise\n\nWhen logging XML payloads, check for the following indicators. If the payload includes encrypted elements, ensure you analyze the decrypted version for a complete assessment. (If encryption is not used, analyze the original XML document directly). This applies to various XML-based authentication and authorization flows, such as SAML Response payloads.\n\n### Multiple SignedInfo Nodes\nThere should not be more than one SignedInfo node inside a Signature. If you find multiple SignedInfo nodes, it could indicate an attack.\n\n```xml\n\u003cSignature\u003e\n \u003cSomeNode\u003e\n \u003cSignedInfo\u003e\n \u003cReference URI=\"somefakereference\"\u003e\n \u003cDigestValue\u003eforgeddigestvalue\u003c/DigestValue\u003e\n \u003c/Reference\u003e\n \u003c/SignedInfo\u003e\n \u003c/SomeNode\u003e\n \u003cSignedInfo\u003e\n \u003cReference URI=\"realsignedreference\"\u003e\n \u003cDigestValue\u003erealdigestvalue\u003c/DigestValue\u003e\n \u003c/Reference\u003e\n \u003c/SignedInfo\u003e\n \u003c/SignedInfo\u003e\n\u003c/Signature\u003e\n```\n\n### Code to test\n\nPass in the decrypted version of the document\n```js\ndecryptedDocument = ... // yours to implement\n\n// This check is per-Signature node, not per-document\nconst signedInfoNodes = xpath.select(\".//*[local-name(.)=\u0027SignedInfo\u0027]\", signatureNode);\n\nif (signedInfoNodes.length === 0) {\n // Not necessarily a compromise, but invalid. Should contain exactly one SignedInfo node\n // Yours to implement\n}\n\nif (signedInfoNodes.length \u003e 1) {\n // Compromise detected, yours to implement\n}\n```", "id": "GHSA-9p8x-f768-wp2g", "modified": "2025-03-16T21:34:47Z", "published": "2025-03-14T17:14:23Z", "references": [ { "type": "WEB", "url": "https://github.com/node-saml/xml-crypto/security/advisories/GHSA-9p8x-f768-wp2g" }, { "type": "ADVISORY", "url": "https://nvd.nist.gov/vuln/detail/CVE-2025-29774" }, { "type": "WEB", "url": "https://github.com/node-saml/xml-crypto/commit/28f92218ecbb8dcbd238afa4efbbd50302aa9aed" }, { "type": "WEB", "url": "https://github.com/node-saml/xml-crypto/commit/886dc63a8b4bb5ae1db9f41c7854b171eb83aa98" }, { "type": "WEB", "url": "https://github.com/node-saml/xml-crypto/commit/8ac6118ee7978b46aa56b82cbcaa5fca58c93a07" }, { "type": "PACKAGE", "url": "https://github.com/node-saml/xml-crypto" }, { "type": "WEB", "url": "https://github.com/node-saml/xml-crypto/releases/tag/v2.1.6" }, { "type": "WEB", "url": "https://github.com/node-saml/xml-crypto/releases/tag/v3.2.1" }, { "type": "WEB", "url": "https://github.com/node-saml/xml-crypto/releases/tag/v6.0.1" }, { "type": "WEB", "url": "https://workos.com/blog/samlstorm" } ], "schema_version": "1.4.0", "severity": [ { "score": "CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N", "type": "CVSS_V4" } ], "summary": "xml-crypto Vulnerable to XML Signature Verification Bypass via Multiple SignedInfo References" }
Sightings
Author | Source | Type | Date |
---|
Nomenclature
- Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
- Confirmed: The vulnerability is confirmed from an analyst perspective.
- Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
- Patched: This vulnerability was successfully patched by the user reporting the sighting.
- Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
- Not confirmed: The user expresses doubt about the veracity of the vulnerability.
- Not patched: This vulnerability was not successfully patched by the user reporting the sighting.