ghsa-qm2q-9f3q-2vcv
Vulnerability from github
Published
2024-08-14 18:11
Modified
2024-08-15 16:58
Severity ?
6.5 (Medium) - CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:H/I:N/A:N
Summary
Trix has a cross-site Scripting vulnerability on copy & paste
Details

The Trix editor, versions prior to 2.1.4, is vulnerable to XSS when pasting malicious code. This vulnerability is a bypass of the fix put in place for https://github.com/basecamp/trix/security/advisories/GHSA-qjqp-xr96-cj99. In https://github.com/basecamp/trix/pull/1149, we added sanitation for Trix attachments with a text/html content type. However, Trix only checks the content type on the paste event's dataTransfer object. As long as the dataTransfer has a content type of text/html, Trix parses its contents and creates an Attachment with them, even if the attachment itself doesn't have a text/html content type. Trix then uses the attachment content to set the attachment element's innerHTML.

Impact

An attacker could trick a user to copy and paste malicious code that would execute arbitrary JavaScript code within the context of the user's session, potentially leading to unauthorized actions being performed or sensitive information being disclosed.

Patches

Update Recommendation: Users should upgrade to Trix editor version 2.1.4 or later, which incorporates proper sanitization of input from copied content.

Workarounds

This is not really a workaround but something that should be considered in addition to upgrading to the patched version. If affected users can disallow browsers that don't support a Content Security Policy, then this would be an effective workaround for this and all XSS vulnerabilities. Set CSP policies such as script-src 'self' to ensure that only scripts hosted on the same origin are executed, and explicitly prohibit inline scripts using script-src-elem.

References

  • https://github.com/basecamp/trix/pull/1156
  • https://github.com/basecamp/trix/releases/tag/v2.1.4
  • https://github.com/basecamp/trix/pull/1149
  • https://github.com/basecamp/trix/security/advisories/GHSA-qjqp-xr96-cj99
  • MDN docs for DataTransfer

Credits

This vulnerability was reported by HackerOne researcher thwin_htet.

Show details on source website

To clipboard 

{
  "affected": [
    {
      "package": {
        "ecosystem": "npm",
        "name": "trix"
      },
      "ranges": [
        {
          "events": [
            {
              "introduced": "0"
            },
            {
              "fixed": "2.1.4"
            }
          ],
          "type": "ECOSYSTEM"
        }
      ]
    }
  ],
  "aliases": [
    "CVE-2024-43368"
  ],
  "database_specific": {
    "cwe_ids": [
      "CWE-79"
    ],
    "github_reviewed": true,
    "github_reviewed_at": "2024-08-14T18:11:53Z",
    "nvd_published_at": "2024-08-14T22:15:04Z",
    "severity": "MODERATE"
  },
  "details": "The Trix editor, versions prior to 2.1.4, is vulnerable to XSS when pasting malicious code. This vulnerability is a bypass of the fix put in place for https://github.com/basecamp/trix/security/advisories/GHSA-qjqp-xr96-cj99. In https://github.com/basecamp/trix/pull/1149, we added sanitation for Trix attachments with a `text/html` content type. However, Trix only checks the content type on the paste event\u0027s `dataTransfer` object. As long as the `dataTransfer` has a content type of `text/html`, Trix parses its contents and creates an `Attachment` with them, even if the attachment itself doesn\u0027t have a `text/html` content type. Trix then uses the attachment content to set the attachment element\u0027s `innerHTML`.\n\n### Impact\nAn attacker could trick a user to copy and paste malicious code that would execute arbitrary JavaScript code within the context of the user\u0027s session, potentially leading to unauthorized actions being performed or sensitive information being disclosed.\n\n### Patches\n**Update Recommendation:** Users should upgrade to Trix editor version 2.1.4 or later, which incorporates proper sanitization of input from copied content.\n\n### Workarounds\nThis is not really a workaround but something that should be considered in addition to upgrading to the patched version. If affected users can disallow browsers that don\u0027t support a Content Security Policy, then this would be an effective workaround for this and all XSS vulnerabilities. Set CSP policies such as `script-src \u0027self\u0027` to ensure that only scripts hosted on the same origin are executed, and explicitly prohibit inline scripts using `script-src-elem`.\n\n### References\n* https://github.com/basecamp/trix/pull/1156\n* https://github.com/basecamp/trix/releases/tag/v2.1.4\n* https://github.com/basecamp/trix/pull/1149\n* https://github.com/basecamp/trix/security/advisories/GHSA-qjqp-xr96-cj99\n* [MDN docs for `DataTransfer`](https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer)\n\n### Credits\n\nThis vulnerability was reported by HackerOne researcher [thwin_htet](https://hackerone.com/thwin_htet?type=user). ",
  "id": "GHSA-qm2q-9f3q-2vcv",
  "modified": "2024-08-15T16:58:47Z",
  "published": "2024-08-14T18:11:53Z",
  "references": [
    {
      "type": "WEB",
      "url": "https://github.com/basecamp/trix/security/advisories/GHSA-qjqp-xr96-cj99"
    },
    {
      "type": "WEB",
      "url": "https://github.com/basecamp/trix/security/advisories/GHSA-qm2q-9f3q-2vcv"
    },
    {
      "type": "ADVISORY",
      "url": "https://nvd.nist.gov/vuln/detail/CVE-2024-43368"
    },
    {
      "type": "WEB",
      "url": "https://github.com/basecamp/trix/pull/1149"
    },
    {
      "type": "WEB",
      "url": "https://github.com/basecamp/trix/pull/1156"
    },
    {
      "type": "WEB",
      "url": "https://github.com/basecamp/trix/commit/7656f578af0d03141a72a9d27cb3692e6947dae6"
    },
    {
      "type": "WEB",
      "url": "https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer"
    },
    {
      "type": "PACKAGE",
      "url": "https://github.com/basecamp/trix"
    },
    {
      "type": "WEB",
      "url": "https://github.com/basecamp/trix/releases/tag/v2.1.4"
    }
  ],
  "schema_version": "1.4.0",
  "severity": [
    {
      "score": "CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:H/I:N/A:N",
      "type": "CVSS_V3"
    }
  ],
  "summary": "Trix has a cross-site Scripting vulnerability on copy \u0026 paste "
}


Log in or create an account to share your comment.




Tags
Taxonomy of the tags.




Sightings

Author Source Type Date

Nomenclature

  • Seen: The vulnerability was mentioned, discussed, or seen somewhere by the user.
  • Confirmed: The vulnerability is confirmed from an analyst perspective.
  • Exploited: This vulnerability was exploited and seen by the user reporting the sighting.
  • Patched: This vulnerability was successfully patched by the user reporting the sighting.
  • Not exploited: This vulnerability was not exploited or seen by the user reporting the sighting.
  • Not confirmed: The user expresses doubt about the veracity of the vulnerability.
  • Not patched: This vulnerability was not successfully patched by the user reporting the sighting.